Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(earn): android header back button #5446

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 21, 2024

Description

On Android the header back button was displayed in the status bar this should fix that issue.

Screenshots

Android Before Android After

Test plan

  • Tested locally on Android.

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@MuckT MuckT enabled auto-merge May 21, 2024 19:00
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (3ab8550) to head (b7e6202).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5446      +/-   ##
==========================================
+ Coverage   86.31%   86.32%   +0.01%     
==========================================
  Files         756      756              
  Lines       31205    31206       +1     
  Branches     5353     5353              
==========================================
+ Hits        26935    26939       +4     
+ Misses       4037     4034       -3     
  Partials      233      233              
Files Coverage Δ
src/earn/EarnEnterAmount.tsx 81.09% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab8550...b7e6202. Read the comment docs.

@MuckT MuckT added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@MuckT MuckT added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit e5f3242 May 21, 2024
17 checks passed
@MuckT MuckT deleted the tomm/header-deposit-more-earn branch May 21, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants