fix(nft-videos): prevent app crash on nft video loads #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5566 +/- ##
==========================================
- Coverage 86.47% 86.46% -0.01%
==========================================
Files 764 764
Lines 31490 31487 -3
Branches 5451 5452 +1
==========================================
- Hits 27230 27226 -4
- Misses 4028 4029 +1
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jh2oman
approved these changes
Jun 24, 2024
1 build increased size
Celo (test) 1.88.0 (153)
|
| Item | Install Size Change |
|---|---|
| Code Signature | ⬆️ 15.7 kB |
| 📝 react_native_video.RCTVideo.Objc Metadata | ⬆️ 10.6 kB |
| 📝 react_native_video.RCTVideo.setSrc | ⬆️ 6.8 kB |
| 📝 react_native_video.RCTVideo.Swift Metadata | ⬆️ 5.7 kB |
| DYLD.Fixups | ⬆️ 5.2 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
### Description Follow up to #5566 where iOS's initial load of iOS could obscure the full screen controls. This also cleans up the navigation options and moves them into `src/nfts/NftsInfoCarousel.tsx`. | iOS Before | iOS After | | ----- | ----- | | <video src="https://github.com/valora-inc/wallet/assets/26950305/f884e901-31d4-42e8-b2f7-b1b6dacb07ca" /> | <video src="https://github.com/valora-inc/wallet/assets/26950305/b55776a9-7e37-42fa-a261-e4e2d95bbb97" /> | ### Test plan - [x] Tested locally on iOS - [x] Tested locally on Android ### Related issues - N/A ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents the app from crashing when attempting to load NFT videos on iOS. It also adjusts the layout for iOS which previously used a header workaround prior to the changes in #5565.
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A