fix: wrong colors import #5570
Merged
fix: wrong colors import #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
approved these changes
Jun 25, 2024
| import { WebViewEvents } from 'src/analytics/Events' | ||
| import ValoraAnalytics from 'src/analytics/ValoraAnalytics' | ||
| import colors from 'src/styles/colors' | ||
| import { Colors } from 'src/styles/colors' |
There was a problem hiding this comment.
we should probably get rid of having both the default and the named export at some point.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5570 +/- ##
========================================
Coverage 86.47% 86.48%
========================================
Files 764 764
Lines 31497 31496 -1
Branches 5452 5452
========================================
+ Hits 27237 27239 +2
+ Misses 4217 4025 -192
- Partials 43 232 +189
... and 78 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bakoushin
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed those 2 incorrect imports.
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: