Feat/tokenomics #54
Merged
Feat/tokenomics #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilelaf
reviewed
May 3, 2022
There was a problem hiding this comment.
Overall looks good but my guess is that we need to modularize this a bit. I still need to study rounds a bit more to understand the equivalent FSM.
- It would be nice see the tests and linters passing, I think you need to merge main to solve the merge conflict.
- I would try to keep abciApps separated in different skills and then chain them (do you have access to any chained example?) as this skill is getting quite large. But not in this PR as it is already big. Let's first focus on having tests.
|
Status update:
|
Closed
dvilelaf
reviewed
May 11, 2022
# Conflicts: # packages/valory/agents/elcollectooorr/aea-config.yaml # packages/valory/contracts/gnosis_safe/contract.py # packages/valory/contracts/gnosis_safe/contract.yaml # packages/valory/skills/elcollectooorr_abci/behaviours.py # packages/valory/skills/elcollectooorr_abci/models.py # packages/valory/skills/elcollectooorr_abci/rounds.py # packages/valory/skills/elcollectooorr_abci/skill.yaml # tests/test_skills/test_fractionalize_deployment_abci/__init__.py # tests/test_skills/test_fractionalize_deployment_abci/test_behaviours.py # tests/test_skills/test_fractionalize_deployment_abci/test_dialogues.py # tests/test_skills/test_fractionalize_deployment_abci/test_payloads.py # tests/test_skills/test_fractionalize_deployment_abci/test_rounds.py
fix/various
# Conflicts: # packages/hashes.csv
feat/happy path e2e test
Integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, but all of the components work, both individually and together 🥳.
TODO:
payloads,behaviours,rounds.Add algorithm updates:Add check whether project is mintable.Check all projects simultaneously.Linting, and other aesthetic fixes.