feat: close connection on too large message #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
requested review from
DavidMinarsch and
marcofavorito
and removed request for
DavidMinarsch
Closed
0xArdi
commented
May 11, 2022
Comment on lines
+1226
to
+1228
| self.channel = cast(Union[TcpServerChannel, GrpcServerChannel], self.channel) | ||
| if self.channel.is_stopped: | ||
| raise ConnectionError("The channel is stopped.") |
There was a problem hiding this comment.
Although the previous solution would ultimately have the same outcome, ie the message failing to get sent or received and an exception raised. However, I think this would be much more easy to reason about. Thanks @marcofavorito 😃 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.