Bagel mech tool #226
Open
Bagel mech tool #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
reviewed
May 22, 2024
| ids=[f"doc_{len(cluster)}"] | ||
| ) | ||
|
|
||
| return "Document added successfully.", None, None, None |
There was a problem hiding this comment.
Remember that this is what will get returned as a response to this request. Is this what was intended?
Is this tool meant to be used in combination with some other tool, or how are you imaging it?
0xArdi
reviewed
May 22, 2024
Comment on lines
+73
to
+77
| return { | ||
| "documents": documents, | ||
| "distances": distances, | ||
| "metadatas": metadatas | ||
| }, None, None, None |
There was a problem hiding this comment.
First element in the returned value is expected to be string.
0xArdi
reviewed
May 22, 2024
| # -*- coding: utf-8 -*- | ||
| # ------------------------------------------------------------------------------ | ||
| # | ||
| # Copyright 2023-2024 Valory AG |
There was a problem hiding this comment.
Small issue, but this is technically expected to be 2024 only. Same for the file above.
|
@BidhanRoy thanks! Changes overall look good. Ideally, we add a bagel key to our CI so we can test here if everything is OK. |
0xArdi
reviewed
May 22, 2024
|
|
||
| from typing import Any, Dict, Optional, Tuple | ||
|
|
||
| import bagelml |
There was a problem hiding this comment.
needs to be added to project deps
|
@BidhanRoy Would be good to addresses the comments above, so we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding Bagel as a mech tool. To be utilized as a resource to generate better inferences via enriched prompts to LLMs.
Fixes
NA.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...