-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be great if response type were something we could pattern-match over #110
Comments
You can pattern match on structs. As for returning an exception instead of a value when connection fails… you're about four years too late with this :) I realize that I probably shouldn't have used exceptions, but back then I thought they were more idiomatic Elixir. I'm not going to commit such huge changes to the public API now. |
That's what new major versions are for :)
…On Wed, May 17, 2017, 16:53 Greg ***@***.***> wrote:
You can pattern match on structs.
As for returning an exception instead of a value when connection fails…
you're about four years too late with this :) I realize that I probably
shouldn't have used exceptions, but back then I thought they were more
idiomatic Elixir. I'm not going to commit such huge changes to the public
API now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJSaIPhWahUL9OUQ3zMV4dd4Uj8Pjbks5r614xgaJpZM4NeZXA>
.
|
Yeah. I don't want to release a new one. I think the API is fine as it is. |
I can't blame you; it's your project :) I have in the meanwhile found Thank you for entertaining my requests! |
oh wow, they not only replaced ibrowse with hackney, but also did that. Nice :) |
So for instance
It would help us get a lot more value out of this tool.
The text was updated successfully, but these errors were encountered: