Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support transforming sample indices. #31

Merged
merged 7 commits into from
Dec 12, 2016
Merged

Add support transforming sample indices. #31

merged 7 commits into from
Dec 12, 2016

Conversation

roryk
Copy link
Collaborator

@roryk roryk commented Dec 8, 2016

This also simplifies the fastqtransform options, removing the
--umi-only and --dual-index options by detecting them from the
regex. Ran tests and diffed the results and they are identical
to the master branch.

Addresses @qfwills comment at COMBINE-lab/salmon#93 about
having everything in one file.

Tagging @vals for a heads up before merging since this removes a couple command line options.

This also simplifies the fastqtransform options, removing the
--umi-only and --dual-index options by detecting them from the
regex. Ran tests and diffed the results and they are identical
to the master branch.

Addresses @qfwills comment at COMBINE-lab/salmon#93 about
having everything in one file.
This is for schemes which store the CB/MB/SB the i5 and i7 read.
@roryk
Copy link
Collaborator Author

roryk commented Dec 9, 2016

Attached a couple other commits to this one:

  1. Added examples for the Broad's DGE scheme, SCRB-seq
  2. Added support for 4 fastq files, some schemes use the i5 and i7 read.
  3. Added an example from the Klein group that has the 4 fastq scheme.
  4. Don't report 0 reads processed when running bamtag.

@roryk roryk merged commit 95e7790 into vals:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant