Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback/audit #34

Merged
merged 10 commits into from
Jul 2, 2024
Merged

feedback/audit #34

merged 10 commits into from
Jul 2, 2024

Conversation

0xashu
Copy link
Contributor

@0xashu 0xashu commented Jun 30, 2024 •
edited
Loading

  • Add SafeCastLib.toUint32 for fromSupply
  • Remove the Aave state check when calling yieldWithdraw / yieldDeposit
  • Remove the timestamp on MigrateYield event
  • Set _subTotal as an internal function
  • Set referralFeePercent to 2%
  • Update the curve params of curveType = 0
  • Update code readability, e.g., curve params

@0xashu
chore: improve readability
2993d6e
@0xashu
chore: remove extra timestamp on event
ab54dc4 
block. timestamp and block, number are added to event information by default so adding them manually wastes gas.
@0xashu
chore: remove Aave check when calling yieldWithdraw
b80234c 
If Aave is frozen, you can also withdraw, see: https://docs.aave.com/faq/frozen-markets-and-reserves.
@0xashu
chore: update default curve params on deployment
3fdb273
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
contracts/core/SharesFactoryV1.sol 98.16% <100.00%> (ø)
contracts/core/aggregator/AaveYieldAggregator.sol 90.00% <ø> (ø)

@0xashu 0xashu requested a review from SocratesLu July 1, 2024 16:23
SocratesLu
SocratesLu reviewed Jul 2, 2024
View reviewed changes
test/unit/SharesFactory.t.sol Show resolved Hide resolved
contracts/core/SharesFactoryV1.sol Show resolved Hide resolved
contracts/core/SharesFactoryV1.sol Show resolved Hide resolved
@0xashu 0xashu merged commit cda0246 into dev Jul 2, 2024
9 checks passed
@0xashu 0xashu deleted the feedback/audit branch July 2, 2024 13:55
@0xashu 0xashu self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SocratesLu SocratesLu SocratesLu left review comments

@aquariuslt aquariuslt aquariuslt approved these changes

Assignees

@0xashu 0xashu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xashu @aquariuslt @SocratesLu