Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please compiled success then commit & push your code. #12

Closed
holys opened this issue Dec 1, 2015 · 4 comments
Closed

Please compiled success then commit & push your code. #12

holys opened this issue Dec 1, 2015 · 4 comments

Comments

@holys
Copy link

holys commented Dec 1, 2015

https://github.com/valyala/fasthttp/blob/master/reuseport/reuseport_bsd.go#L5

Missing import syscall

Suggestions:

  1. Use travis CI or something else
  2. Use goimports instead of gofmt to prevent such minor mistake.
valyala added a commit that referenced this issue Dec 1, 2015
@valyala
Copy link
Owner

valyala commented Dec 1, 2015

@holys, thanks for the bug report! I missed this import because I work in x64 ubuntu and don't cross-compile fasthttp for other architectures and/or OSes (

Will look into travis CI and goimports

valyala added a commit that referenced this issue Dec 1, 2015
@valyala
Copy link
Owner

valyala commented Dec 1, 2015

Hmm, I couldn't figure out how to properly set up cross-compiled tests in .travis.yml .
@holys , could you help me with this?

@holys
Copy link
Author

holys commented Dec 2, 2015

@valyala

Have you tried gox? That makes cross-compiling easy.
Here is the example provided by travis ci:

reference:

P.S. You may add the travis ci build status image to your README.md

Build Status

[![Build Status](https://travis-ci.org/valyala/fasthttp.svg)](https://travis-ci.org/valyala/fasthttp)

This image could be found from your travis repo page, just click the build status image that.

@valyala
Copy link
Owner

valyala commented Dec 2, 2015

Done

@valyala valyala closed this as completed Dec 2, 2015
zwirec pushed a commit to zwirec/fasthttp that referenced this issue Jul 12, 2018
link to fork of fasthttprouter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants