Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset RequestCtx.s #1234

Merged
merged 1 commit into from Mar 4, 2022
Merged

Don't reset RequestCtx.s #1234

merged 1 commit into from Mar 4, 2022

Conversation

erikdubbelboer
Copy link
Collaborator

@erikdubbelboer erikdubbelboer commented Mar 3, 2022

RequestCtx's are reused in a server specific pool, so no need to reset it. This fixes a use after reset but when RequestCtx is use as context.

Fixes #1205

RequestCtx's are reused in a server specific pool, so no need to reset
it. This fixes a use after reset but when RequestCtx is use as context.

Fixes #1205
@erikdubbelboer erikdubbelboer merged commit 62c15a5 into master Mar 4, 2022
8 of 11 checks passed
@erikdubbelboer erikdubbelboer deleted the no-reset-ctx-s branch Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant