Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos-14 platform, enable shuffle of unit-tests #1746

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add macos-14 platform, enable shuffle of unit-tests #1746

merged 1 commit into from
Apr 10, 2024

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Apr 2, 2024

  • Add macos-14 platform which uses Apple M1 cpu's (ARM64).
  • Add -shuffle=on to enable shuffling the unit-tests order. Each run will run tests in different order to catch tests depending on others or using data from other tests.

We recently enabled both of these options in gofiber with great success. https://github.com/gofiber/fiber/blob/main/.github/workflows/test.yml#L37

@gaby
Copy link
Contributor Author

gaby commented Apr 2, 2024

@erikdubbelboer The test that failed is known to fail?

@erikdubbelboer erikdubbelboer merged commit d3aa5a1 into valyala:master Apr 10, 2024
18 of 19 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks! Indeed some of our tests are a bit flakey.

@gaby gaby deleted the shuffle-arm branch April 10, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants