Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/18 existent joins #19

Merged
merged 4 commits into from
May 28, 2020
Merged

Patch/18 existent joins #19

merged 4 commits into from
May 28, 2020

Conversation

albertored
Copy link
Collaborator

Closes #18

Ecto.Query internal struct format has changed, with this commit
we restore the support for filtering from queries

`(form u in User) |> ExSiseve.filter(params, config)`
we can avoid adding duplicated joins only if they use named bindings
and if the name is the same
@ekarak
Copy link

ekarak commented May 28, 2020

this works great, lets merge this!

@albertored albertored merged commit 16cd9e8 into master May 28, 2020
@albertored albertored deleted the patch/18-existent-joins branch June 25, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Repo.filter() work with Ecto.Query (Ecto 3.4.4)
2 participants