Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error checking of where clauses #20

Merged
merged 8 commits into from
Jun 25, 2020
Merged

Improve error checking of where clauses #20

merged 8 commits into from
Jun 25, 2020

Conversation

albertored
Copy link
Collaborator

Multiple improvements in this PR:

  • add field type to ExSieve.Node.Attribute struct
  • return an error or discard attribute if the predicate does not support the given type
  • validate true value for boolean predicates (true, not_true, false, not_false, present, blank, null, not_null
  • exclude meaninglessly all/any composite predicates
  • escape like queries
  • test all predicates

@albertored albertored merged commit 42bdc70 into master Jun 25, 2020
@albertored albertored deleted the types branch June 25, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant