Add string versions of @true_values as well #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to upgrade ex_sieve over hex.pm. @valyukov, could you bump version to 0.6.1, plz? |
|
@s33m4nn here we go https://hex.pm/packages/ex_sieve/0.6.1 |
|
@valyukov Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExSieve.Builder.Wheremodule's@true_valuesmodule attribute does not contain the string versions of true values only the charlist ones. For example making a request likehttp://localhost:4000/users?q[name_null]=trueto list the users with null as a name will result in no function clause matching in ExSieve.Builder.Where.predicat_expr/3 error because the true parameter gets passed as a string not a charlist. This PR fixes that.