Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu item on gloss: 'Show in Signbank' #9

Closed
ocrasborn opened this issue Mar 5, 2016 · 16 comments
Closed

Add menu item on gloss: 'Show in Signbank' #9

ocrasborn opened this issue Mar 5, 2016 · 16 comments

Comments

@ocrasborn
Copy link
Collaborator

  • For a selected gloss on a tier that is linked to an ECV with Signbank references, add an item in its contextual menu that says "Show in Signbank"
  • Suggested location: below "Modify annotation data category"
  • Action: open default web browser and jump to detail view of that gloss
  • Assumes user is logged in in Signbank

screenshot 2016-03-05 12 07 31

@vanlummelhuizen
Copy link
Owner

Is it possible to have a reference to Signbank in an ECV?

@vanlummelhuizen
Copy link
Owner

@ocrasborn Alright. I have given it some more thought. Some explanation of my earlier comment: to make this function generic for all future Signbanks, where ever they are hosted, we need some way to determine that an ECV reference is without a doubt a Signbank-ECV reference. We could for now use the heuristic 'is the text "signbank" in the reference url', but it may result in 'page not found's if it is actually not a Signbank.
Also, we need a way to determine the path to a gloss, after the host name. Is it always '/dictionary/gloss/'?
I will implement a non-future proof version that can be altered when needed.

@henrinie
Copy link

henrinie commented Jul 13, 2016

@vanlummelhuizen

Is it always '/dictionary/gloss/'?

It might not always be that, but it is always possible to redirect that url to the correct one.

@vanlummelhuizen
Copy link
Owner

@henrinie Alright, but that implies that the ELAN user will have that power to make that happen somehow. And the path may actually be used for something else. (Perhaps I am too much of a pessimist.)
Anyway, since the connection between ELAN and Signbank will be completely different in the hopefully near future, this is not a great concern. The near future involves setting the Signbank url and credentials and downloading all necessary Signbank data on you local disk for ELAN to read. A kind of ECV++.

@henrinie
Copy link

@vanlummelhuizen That sounds great.
You are not being too pessimistic, if it can fail it will, right? :)

The near future involves setting the Signbank url and credentials and downloading all necessary Signbank data on you local disk for ELAN to read. A kind of ECV++.

Will that support https?

@vanlummelhuizen
Copy link
Owner

@henrinie From an ELAN point of view, it can be either http or https. We could demand https. From a Signbank point of view I would hope https is at least a possibility. Perhaps @Woseseltops can chip in here.

@henrinie
Copy link

@vanlummelhuizen I really hope it will be https only.
From signbank point of view https definitely is a possibility, the only thing stopping us (FinSL-signbank) from enforcing https only is that I can't get the ECV export to work in ELAN via https.

@vanlummelhuizen
Copy link
Owner

Ah, good point. I am going to check if https could be added for ECVs.

@vanlummelhuizen
Copy link
Owner

@ocrasborn This is implemented now. You can download the new jar. A few things are hardcoded:

  • there should be 'signbank' somewhere in the ECV-url
  • the path of the url is '/dictionary/gloss/'
  • the id is taken from the CV-entry reference, but without the leading text 'gloss'

@vanlummelhuizen
Copy link
Owner

@henrinie I tested using an ECV over a https connection. It works as it should so there might be a problem with your https connections. You could investigate using these helpful urls: https://www.ssllabs.com/ssltest/analyze.html and http://www.digicert.com/help

I problem I encountered before was a broken certificate chain, which means your specific https certificate does not refer to one of the worlds main certificate authorities.

@henrinie
Copy link

henrinie commented Jul 19, 2016

Sorry for the off topic in this issue.
@vanlummelhuizen Thanks for the tips. I ran those tests:
https://www.digicert.com/help/ gives all green, and
https://www.ssllabs.com/ssltest/analyze.html grades the cert as A.

It might be that I have some other problem too.
ELAN gives me a Warning: Could not read the file:, when I try with the https address instead of the http one (which works). This is with ELAN 4.9.4 on Linux.

If you have a test ecv online behind https I would like to test it if possible.

@vanlummelhuizen
Copy link
Owner

@henrinie This is interesting: when started from a regular installation, I encounter the problems you describe. But when started from my development environment (Eclipse IDE), there is no problem. I reckon it can be easily fixed, but finding that solution may take a while. Perhaps I contact Han Sloetjes (main devoper of ELAN, Max Planck Institute Nijmegen) about this. I will let you know.

@vanlummelhuizen
Copy link
Owner

@henrinie Ok, I came this far: starting ELAN from Eclipse or directly from the commandline makes it accept https. When starting from the installation script (InstallAnywhere/LaunchAnywhere) https is not accepted. I think I will mail Han Sloetjes now, since the responsibility for this lies with him. I will let him know that it is like this on Ubuntu. What OS are you using?

@henrinie
Copy link

@vanlummelhuizen Thank you for testing this.
I am using RHEL 7.2 (Red Hat Enterprise Linux), Kernel 3.10.0-327.
I can test it on Fedora linux too if needed. And also on any livecd available.

@vanlummelhuizen
Copy link
Owner

@henrinie I just tested it on Window 7 and I got the same problem. Han will look into this next week. I will keep you posted.

@ocrasborn
Copy link
Collaborator Author

Tested; works fine.

vanlummelhuizen added a commit to Signbank/Global-signbank that referenced this issue Feb 27, 2017
… External Reference for opening a Signbank entry from a ECV entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants