Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored if statement in __rpc_call to improve readability #213

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Refactored if statement in __rpc_call to improve readability #213

merged 1 commit into from
Jan 30, 2024

Conversation

andreped
Copy link
Contributor

This is a tiny PR only affecting one statement in the __rpc_call() method.

The if statement logic starts with a not, which IMO does not make much sense and makes the code harder to read.

I have corrected for this.

zainhoda
zainhoda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@zainhoda zainhoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to merge this in for now but I'm going to be deprecating every function in this file soon as it's legacy before we were really fully open-source. None of the functions in this file use the base class.

@zainhoda zainhoda merged commit aa432ab into vanna-ai:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zainhoda zainhoda zainhoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreped @zainhoda