Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter exact, prefix and suffix support event data #379

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Dec 30, 2022

Signed-off-by: delu delu.xu@linkall.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

  • filter exact, prefix, and suffix support event data

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #379 (39ddcc6) into main (09f3748) will decrease coverage by 3.06%.
The diff coverage is 50.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   62.72%   59.65%   -3.07%     
==========================================
  Files         133      172      +39     
  Lines       12128    14181    +2053     
==========================================
+ Hits         7607     8460     +853     
- Misses       3977     5127    +1150     
- Partials      544      594      +50     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b23e5a...39ddcc6. Read the comment docs.

internal/trigger/filter/common.go Outdated Show resolved Hide resolved
@wenfengwang
Copy link
Contributor

fix lint

xdlbdy and others added 2 commits January 6, 2023 17:07
Signed-off-by: delu <delu.xu@linkall.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 2789120 into vanus-labs:main Jan 7, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: exact, perfix and suffix support data

Signed-off-by: delu <delu.xu@linkall.com>

* feat: exact, perfix and suffix support data

Signed-off-by: xdlbdy <xdlbdy@gmail.com>

Signed-off-by: delu <delu.xu@linkall.com>
Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants