Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tenant): suppress creating the default namespace automatically #623

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Sep 6, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #623 (9e2828f) into main (ee76217) will decrease coverage by 3.19%.
Report is 85 commits behind head on main.
The diff coverage is 46.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   57.07%   53.88%   -3.19%     
==========================================
  Files         190      225      +35     
  Lines       15191    18160    +2969     
==========================================
+ Hits         8670     9786    +1116     
- Misses       5884     7581    +1697     
- Partials      637      793     +156     
Files Changed Coverage
internal/controller/trigger/storage/storage.go ø
...rnal/controller/trigger/validation/subscription.go ø
internal/controller/trigger/worker/manager.go ø
internal/controller/trigger/worker/policy.go ø
internal/controller/trigger/worker/scheduler.go ø
internal/controller/trigger/worker/worker.go ø
internal/gateway/config.go ø
internal/gateway/gateway.go ø
internal/gateway/proxy/auth.go ø
internal/gateway/proxy/deadletter.go ø
... and 68 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2735bb4...9e2828f. Read the comment docs.

@ifplusor ifplusor merged commit b1a564e into vanus-labs:main Sep 6, 2023
3 of 5 checks passed
@ifplusor ifplusor changed the title feat: add config decode auto create default namespace feat(tenant): suppress creating the default namespace automatically Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants