New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: remove warning for key uri when key is set via env/args #66

Merged

lazypower merged 1 commit into master from log-msg-fix

Jul 13, 2020

Contributor

edaniszewski commented Jul 13, 2020

This PR:

Removes the log message warning about missing key URI on add, as it was misleading when key was set via env/args, and was unnecessary when key was not otherwise set (since it terminates in error)

fixes #64

edaniszewski requested a review from lazypower

July 13, 2020 13:07

lazypower suggested changes

View reviewed changes

Contributor

lazypower left a comment

This is a nit, but do you mind bumping the revision along with this so we can just cut a release? <3


          bugfix: remove warning for key uri when key is set via env/args

a3d3e77

edaniszewski force-pushed the log-msg-fix branch from 33b1e2a to a3d3e77 Compare

July 13, 2020 13:40

lazypower approved these changes

View reviewed changes

lazypower merged commit a403d55 into master

lazypower deleted the log-msg-fix branch

July 13, 2020 13:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet