Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of legacy codepath when establishing Postgres connections #249

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 11, 2023

Also tidies CI as usual.

@gwynne gwynne added the semver-patch Internal changes only label Aug 11, 2023
@gwynne gwynne requested review from 0xTim and MahdiBM August 11, 2023 01:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #249 (544c9b7) into main (e0f6bc9) will increase coverage by 0.17%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   36.10%   36.27%   +0.17%     
==========================================
  Files          13       13              
  Lines         734      736       +2     
==========================================
+ Hits          265      267       +2     
  Misses        469      469              
Files Changed Coverage Δ
Sources/PostgresKit/PostgresConnectionSource.swift 100.00% <100.00%> (ø)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @14s seem suspicious 🤔

@gwynne gwynne dismissed MahdiBM’s stale review August 11, 2023 01:48

The 14s are deliberate.

@gwynne gwynne merged commit 81d1106 into main Aug 11, 2023
20 checks passed
@gwynne gwynne deleted the fix-legacy-codepath branch August 11, 2023 02:27
@penny-for-vapor
Copy link

These changes are now available in 2.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants