Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepare(query:) when no data returned #123

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix prepare(query:) when no data returned #123

merged 2 commits into from
Aug 20, 2020

Conversation

Jerry-Carter
Copy link
Contributor

@Jerry-Carter Jerry-Carter commented Aug 19, 2020 •
edited by tanner0101
Loading

Fixes prepare(query:) when used with queries that return no results (like DELETE ...) (#123, fixes #122).

@Jerry-Carter Jerry-Carter mentioned this pull request Aug 19, 2020
Closed
@tanner0101 tanner0101 added bug Something isn't working semver-patch labels Aug 20, 2020
@tanner0101 tanner0101 changed the title Updated prepared query handling to work when no results are returned Fix PreparedQuery force unwrap when no results returned Aug 20, 2020
@tanner0101 tanner0101 changed the title Fix PreparedQuery force unwrap when no results returned Fix PreparedQuery when no data returned Aug 20, 2020
@tanner0101 tanner0101 changed the title Fix PreparedQuery when no data returned Fix prepare(query:) when no data returned Aug 20, 2020
tanner0101
tanner0101 approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanner0101 tanner0101 merged commit dddb196 into vapor:master Aug 20, 2020
@tanner0101
Copy link
Member

These changes are now available in 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a prepared statement for a delete generates a fatalError
2 participants
@Jerry-Carter @tanner0101