Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PostgresNIO.testJSONBSerialize non throwing #140

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Make PostgresNIO.testJSONBSerialize non throwing #140

merged 1 commit into from
Feb 18, 2021

Conversation

fabianfett
Copy link
Collaborator

Refactor PostgresNIO.testJSONBSerialize to get better error diagnostics in case of unexpected errors.

gwynne
gwynne approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gwynne gwynne added the enhancement New feature or request label Feb 18, 2021
@gwynne gwynne merged commit 3830928 into vapor:master Feb 18, 2021
@fabianfett fabianfett mentioned this pull request Feb 18, 2021
Merged
@fabianfett fabianfett deleted the ff-rewrite-json-test branch February 26, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @gwynne