Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple streams #442

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add support for multiple streams #442

merged 1 commit into from
Nov 14, 2023

Conversation

fabianfett
Copy link
Collaborator

Actually add support for connections with more than one stream.

@fabianfett fabianfett added semver-patch No public API change. ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule labels Nov 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #442 (3c4173a) into main (dc94503) will increase coverage by 0.21%.
The diff coverage is 80.76%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   59.42%   59.64%   +0.21%     
==========================================
  Files         124      124              
  Lines        9820     9889      +69     
==========================================
+ Hits         5836     5898      +62     
- Misses       3984     3991       +7
Files Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 92.82% <100.00%> (+0.82%) ⬆️
...nPoolModule/PoolStateMachine+ConnectionGroup.swift 88.52% <82.35%> (+1.06%) ⬆️
...ources/ConnectionPoolModule/PoolStateMachine.swift 86.96% <87.09%> (-1.42%) ⬇️
...nPoolModule/PoolStateMachine+ConnectionState.swift 84.59% <70.37%> (-0.70%) ⬇️

... and 1 file with indirect coverage changes

@fabianfett fabianfett added semver-minor Adds new public API. and removed semver-patch No public API change. labels Nov 14, 2023
@fabianfett
Copy link
Collaborator Author

API changes in ConnectionPoolModule.

@fabianfett fabianfett merged commit 54f491c into vapor:main Nov 14, 2023
11 of 12 checks passed
@fabianfett fabianfett deleted the ff-add-support-multiple-streams branch November 14, 2023 14:49
@fabianfett fabianfett added this to the ConnectionPool milestone Nov 14, 2023
@fabianfett fabianfett mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-minor Adds new public API.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianfett @codecov-commenter @gwynne