This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Speed up TemplateDataEncoder significantly.
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results: - Before the optimizations, each invocation inside `measure` takes about 4s on my Core i7-6700k. - After conforming `Data` to `TemplateDataRepresentable`, each invocation inside `measure` takes about 0.2s. - After rewriting `TemplateDataEncoder`, the runtime halves again to 0.1s. (`NestedData` is fairly inefficient, especially for "deeper" hierarchies.)
MrMage
added a commit
to MrMage/core
that referenced
this pull request
Apr 1, 2019
…ten`. This further halves the runtime in vapor/template-kit#50 from 0.1s to 50ms.
MrMage
added a commit
to MrMage/core
that referenced
this pull request
Apr 1, 2019
…ten`. This further halves the runtime in vapor/template-kit#50 from 0.1s to 50ms.
tanner0101
pushed a commit
to vapor/core
that referenced
this pull request
Apr 3, 2019
…ten (#199) * Significantly improve the performance of `Collection<FutureType>.flatten`. This further halves the runtime in vapor/template-kit#50 from 0.1s to 50ms. * Add a benchmark for `flatten`.
tanner0101
previously approved these changes
Apr 12, 2019
There was a problem hiding this comment.
This looks great. It looks like a similar method to what I've been using for Vapor 4's encoders. See this one for example: https://github.com/vapor/leaf/pull/139/files#diff-a1f7fd8772e8db228f62e4a0b303ee06R1
|
Looks like there is a CI failure: |
Thanks for spotting that! I've updated the tests now; hopefully this will be fixed now. |
|
Weird; on Mac the |
|
Added a manual implementation of |
MrMage
force-pushed
the
performance-improvements
branch
from
78e4bdf
to
d3755cc
Compare
|
Hey @MrMage, you just merged a pull request, have a coin! You now have 26 coins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results:
measuretakes about 4s on my Core i7-6700k.DatatoTemplateDataRepresentable, each invocation insidemeasuretakes about 0.2s.TemplateDataEncoder, the runtime halves again to 0.1s. (NestedDatais fairly inefficient, especially for "deeper" hierarchies.)Screenshot (including the improvements from vapor/core#199):
