Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version flag #19

Closed
finestructure opened this issue May 27, 2016 · 2 comments
Closed

Add a version flag #19

finestructure opened this issue May 27, 2016 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@finestructure
Copy link
Sponsor Member

I’m getting increasingly confused while working on the vapor script which one it actually is, especially when I install them somewhere and then run self-update. This would probably also be useful for self-update to report what versions it’s dealing with.

Not sure what the best mechanism would be for this. Since we distribute only the actual script itself, it would either have to be a (manually updated) variable inside the script that a version command echoes. Or we could have the script run an md5 or sha1 sum on itself and return that.

The latter option would mean there’s no need to maintain a version variable but the downside is we’d either need to pull in some pure swift implementation of md5 or sha1 or find a command line tool that’s widely available to do a system call for.

OSX has md5 but the ubuntu 14.04 I just checked doesn’t.

A variable is probably best even though there’s a good chance it’ll grow stale. The hash option feels like overkill.

PS: If I get the compiled version of the vapor script to run on Linux and in case that becomes the default way to install it, a hash function in the script should to ok performance wise, although the source file would get bigger.

@finestructure finestructure added the enhancement New feature or request label May 27, 2016
@tanner0101
Copy link
Member

I think a variable inside of the file would be best. We can police each other in the PR process to increment the version number.

@tanner0101 tanner0101 added this to the 0.5 milestone May 27, 2016
@tanner0101
Copy link
Member

tanner0101 commented May 27, 2016

I've added this to milestone 0.5. Let's make that the first versioned version.

tanner0101 added a commit that referenced this issue Jul 17, 2017
fix distribute script to remove sqlite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants