Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using git remote show instead of git remote get-url #21

Merged
merged 1 commit into from
May 29, 2016

Conversation

nsomar
Copy link
Member

@nsomar nsomar commented May 29, 2016

Using remote show instead of remote get-url.

get-url was introduced in git 2.7, which makes vapor heroku init fail on vanilla git installed on Mac OSX el capitan (mine was 2.6.1).

Note: I couldn't find when remote show was added to git, but its before git 1.5 (Sep 2010)

@loganwright
Copy link
Member

@oarrabi works on my end, I'll merge for now. Do you know of an easy way to execute the command without logging to console? It's showing the branches, but what we really want is just a way to tell if heroku is already created.

@loganwright loganwright merged commit 20b6164 into vapor:master May 29, 2016
@nsomar
Copy link
Member Author

nsomar commented May 29, 2016

I think we can route the STDout to file, and then check the exit code.
When the git remote show XXX is exectured, if XXX is not found the status code will be 1, we can check on that.

Il create an issue on github so we can work on it later, sounds good?
Or do you have another place to track tasks and features (ie trello, jira, etc..) ?

@loganwright
Copy link
Member

Sounds good to me, we track w/ Github issues for now, we'll break it out when/if issue tracking becomes too complex.

@tanner0101 tanner0101 added the enhancement New feature or request label May 31, 2016
@tanner0101 tanner0101 added this to the 0.5 milestone May 31, 2016
tanner0101 added a commit that referenced this pull request Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants