-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPT 251.600 RGBW added #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the contribution!
There are just a few things to be addressed, then it can be merged :)
knx/dpt/formats.go
Outdated
@@ -30,6 +30,40 @@ func unpackB1(data []byte, b *bool) error { | |||
return nil | |||
} | |||
|
|||
func packB4(b0 bool, b1 bool, b2 bool, b3 bool) byte { | |||
var b int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be of type byte
(or uint8
).
Thank you very much. Then I can remove following line of my go.mod :)
|
This pull request adds DPT 251.600. As it is a combined data type I thought the best solution is to create a struct for the 4 color
unit8
and 4 color valid bits.What do you think?