Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add capability to build without ui #417

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

nlevee
Copy link
Collaborator

@nlevee nlevee commented Nov 18, 2023

No description provided.

@nlevee nlevee requested a review from varbhat November 18, 2023 23:35
@nlevee nlevee self-assigned this Nov 18, 2023
@nlevee nlevee added the enhancement New feature or request label Nov 18, 2023 — with GitHub Codespaces
@mckaygerhard
Copy link

i guess this PR has no sense.. currently the fearture of exatorrent is the webui .. cos as command line only there is another tools like aria2c

@nlevee
Copy link
Collaborator Author

nlevee commented Nov 19, 2023

i guess this PR has no sense.. currently the fearture of exatorrent is the webui .. cos as command line only there is another tools like aria2c

aria2c is a cmd line not an API, so it cannot be control easily.

As the README.md said :

Thanks to documented WebSocket API of exatorrent, custom client can be created.

So I think that if a user want to build his own client it can be interesting not to build the webui.

@mckaygerhard
Copy link

i guess this PR has no sense.. currently the fearture of exatorrent is the webui .. cos as command line only there is another tools like aria2c

aria2c is a cmd line not an API, so it cannot be control easily.

aria2c provides a library for that

"user" mean no so much skilss to code.. and a programmer not made a socket to control another app that already has sockets.. that-s why aria2c idea

@nlevee
Copy link
Collaborator Author

nlevee commented Nov 20, 2023

This PR has no impact on user experience, it only permits to develop another webui if anyone want to do it, and/or permits to develop feature on webui by exposing webui with a node dev server without rebuild Golang application. It speeds up development cycle and permit to develop more feature in less time (it's what we call DevX).

I can explain what's DevX and why it's important for a project to grow up if you want ?

@varbhat varbhat merged commit 426e2c5 into main Nov 20, 2023
@varbhat varbhat deleted the feat/build-without-ui branch November 20, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants