remove serde.retention, use retention.max-hr * hour_seconds #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chenqin
commented
Dec 14, 2020
chenqin
commented
- group max-mb max-hr under retention configuration
- remove ser.retention use max-hr double value multiple with 3600 as kafka ingestion retention config
eviction configuration, put max-mb, max-hr under same yaml config
chenqin
changed the title
shawncao
requested changes
Dec 14, 2020
src/meta/ClusterInfo.cpp
Outdated
| auto retention = node["retention"]; | ||
| if (retention) { | ||
| serde.retention = retention.as<uint64_t>(); | ||
| } | ||
| serde.retention = (uint64_t) retention; |
There was a problem hiding this comment.
This retention is KAFKA topic retention in Kafka store, not the max-hr (retention in Nebula), the usage of this value is used to estimate offset and range for each Kafka split when early version of Kafka doesn't have watermark/offset feature, we should leave this as it is.
There was a problem hiding this comment.
got it, how about rename to topic-retention to avoid confusion.
shawncao
approved these changes
Dec 14, 2020
|
Notice to upgrade table compatible with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.