Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-1 removed defer #1

Merged
merged 2 commits into from Aug 12, 2018
Merged

wp-1 removed defer #1

merged 2 commits into from Aug 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #1   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          32     30    -2     
=====================================
- Hits           32     30    -2
Impacted Files Coverage Δ
pool.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bce63...cb2aca0. Read the comment docs.

@vardius
Copy link
Owner

vardius commented Aug 9, 2018

Can you explain what problem this solves, how does it help ?

The idea of running grouting here was for Delegate function to not block when adding jobs to full queue. Sends to a buffered channel block only when the buffer is full.

@ghost
Copy link
Author

ghost commented Aug 10, 2018

In your delegate function, there are chances that the goroutine won't run at all since delgate function has not other commnd to run after the goroutine has started.Delegate function will sometimes end even before the goroutine has completed

@vardius
Copy link
Owner

vardius commented Aug 10, 2018

@siddhant2408 could you add a test case for it ? That breaks now and will work after your changes ?

@vardius vardius merged commit 3c1740f into vardius:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants