Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image-preview): prohibit triggering long press event when pinch zoom #1156

Closed
wants to merge 1 commit into from

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Aug 21, 2023

Checklist

List of tasks you have already done and plan to do.

  • prohibit triggering long press event when pinch zoom

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

Reproduction link.
Try it.
image

@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 6:43am

@vercel
Copy link

vercel bot commented Aug 21, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1156 (d450b2f) into dev (cef0d36) will decrease coverage by 0.02%.
Report is 3 commits behind head on dev.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##              dev    #1156      +/-   ##
==========================================
- Coverage   95.74%   95.72%   -0.02%     
==========================================
  Files         337      337              
  Lines       22098    22104       +6     
  Branches     2180     2178       -2     
==========================================
+ Hits        21158    21160       +2     
- Misses        825      893      +68     
+ Partials      115       51      -64     
Files Changed Coverage Δ
...kages/varlet-ui/src/image-preview/ImagePreview.vue 97.93% <86.66%> (-0.23%) ⬇️

... and 29 files with indirect coverage changes

@chouchouji
Copy link
Member Author

chouchouji commented Aug 21, 2023

image
I added the judgment of the number of touch points to fix this bug for the long press event.
In the next major version, I will refactor the logic here with reference to hammerjs
@haoziqaq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant