Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify props definition and optimize types #1162

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Aug 25, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Aug 25, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 6:57am

@chouchouji chouchouji changed the title refactor: simplify props definition and optimize types WIP: simplify props definition and optimize types Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1162 (0f657ec) into dev (b452a40) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1162      +/-   ##
==========================================
- Coverage   95.65%   95.50%   -0.15%     
==========================================
  Files         337      337              
  Lines       21727    20937     -790     
  Branches     2132     2095      -37     
==========================================
- Hits        20782    19995     -787     
+ Misses        894      891       -3     
  Partials       51       51              
Files Changed Coverage Δ
packages/varlet-ui/src/app-bar/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/checkbox-group/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/chip/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/collapse-item/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/collapse/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/counter/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/date-picker/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/dialog/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/divider/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/drag/props.ts 100.00% <100.00%> (ø)
... and 45 more

@chouchouji chouchouji changed the title WIP: simplify props definition and optimize types refactor: simplify props definition and optimize types Aug 25, 2023
@haoziqaq haoziqaq merged commit c84dc6c into varletjs:dev Aug 25, 2023
5 of 6 checks passed
@chouchouji chouchouji deleted the refactor-components branch September 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants