Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: color-picker #1175

Closed
wants to merge 2 commits into from
Closed

feat: color-picker #1175

wants to merge 2 commits into from

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Sep 5, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:49am

@vercel
Copy link

vercel bot commented Sep 5, 2023

@ErKeLost is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 42.93% and project coverage change: -5.18% ⚠️

Comparison is base (bc15462) 93.42% compared to head (a5fd7be) 88.24%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1175      +/-   ##
==========================================
- Coverage   93.42%   88.24%   -5.18%     
==========================================
  Files         284      301      +17     
  Lines        6193     6901     +708     
  Branches     1498     1656     +158     
==========================================
+ Hits         5786     6090     +304     
- Misses        344      668     +324     
- Partials       63      143      +80     
Files Changed Coverage Δ
...es/varlet-ui/src/color-picker/utils/color-utils.ts 26.15% <26.15%> (ø)
...es/varlet-ui/src/color-picker/utils/dom-dragger.ts 37.93% <37.93%> (ø)
...olor-picker-hue-slider/color-picker-hue-slider.tsx 38.00% <38.00%> (ø)
...onents/color-picker-canvas/color-picker-canvas.tsx 44.44% <44.44%> (ø)
...-picker-alpha-slider/color-picker-alpha-slider.tsx 45.83% <45.83%> (ø)
...s/color-picker-canvas/color-picker-canvas-types.ts 50.00% <50.00%> (ø)
...lor-picker-swatches/color-picker-swatches-types.ts 50.00% <50.00%> (ø)
...nents/color-picker-edit/color-picker-edit-types.ts 66.66% <66.66%> (ø)
...ckages/varlet-ui/src/color-picker/utils/helpers.ts 66.66% <66.66%> (ø)
...components/color-picker-edit/color-picker-edit.tsx 68.18% <68.18%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to change the file name to index.tsx/less/ts

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to change the file name to index.tsx/less/ts

@haoziqaq haoziqaq closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants