Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploader): readonly mode allows to preview picture #1184

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Sep 19, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 8:49am

@vercel
Copy link

vercel bot commented Sep 19, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8a8dee7) 93.01% compared to head (671813c) 93.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1184   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         284      284           
  Lines        6243     6243           
  Branches     1519     1519           
=======================================
  Hits         5807     5807           
  Misses        373      373           
  Partials       63       63           
Files Changed Coverage Δ
packages/varlet-ui/src/uploader/Uploader.vue 94.11% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoziqaq haoziqaq merged commit edcf93a into varletjs:dev Sep 19, 2023
4 checks passed
@chouchouji chouchouji deleted the fix-uploader branch September 19, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants