Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploader): convert default slot to boolean value #1188

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Sep 22, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Sep 22, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 4:07pm

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (842b10c) 93.09% compared to head (55dd1bd) 93.08%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1188      +/-   ##
==========================================
- Coverage   93.09%   93.08%   -0.01%     
==========================================
  Files         284      284              
  Lines        6252     6251       -1     
  Branches     1519     1518       -1     
==========================================
- Hits         5820     5819       -1     
  Misses        370      370              
  Partials       62       62              
Files Changed Coverage Δ
packages/varlet-ui/src/uploader/Uploader.vue 94.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoziqaq haoziqaq merged commit 4416972 into varletjs:dev Sep 22, 2023
3 of 4 checks passed
@chouchouji chouchouji deleted the fix-uploader branch September 26, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants