Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): replace type StyleValue with CSSProperties #1198

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Sep 28, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 7:26am

@vercel
Copy link

vercel bot commented Sep 28, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a8fbb35) 93.38% compared to head (95e0d9e) 93.38%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1198   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         285      285           
  Lines        6254     6254           
  Branches     1516     1515    -1     
=======================================
  Hits         5840     5840           
  Misses        356      356           
  Partials       58       58           
Files Coverage Δ
packages/varlet-ui/src/app-bar/AppBar.vue 100.00% <100.00%> (ø)
...ackages/varlet-ui/src/avatar-group/AvatarGroup.vue 100.00% <100.00%> (ø)
packages/varlet-ui/src/cell/Cell.vue 93.75% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoziqaq haoziqaq merged commit cb1b3a3 into varletjs:dev Sep 28, 2023
5 of 6 checks passed
@chouchouji chouchouji deleted the refactor-components branch September 28, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants