-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(switch): support variant mode #1552
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@YHoney7 is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1552 +/- ##
==========================================
- Coverage 92.81% 92.79% -0.03%
==========================================
Files 305 305
Lines 7167 7173 +6
Branches 1780 1786 +6
==========================================
+ Hits 6652 6656 +4
- Misses 449 451 +2
Partials 66 66 ☔ View full report in Codecov by Sentry. |
playground 显示似乎有些问题。 |
还有一个问题就是 ripple 似乎有点过于大了。 |
props.size 似乎在 variant 模式下没有适配 |
我看下playground是有问题, ripple的尺寸目前是对比figma标注的尺寸的 |
参考md3, 间距还有样式好像不太对 |
|
收到👌 |
影响到了form的快照,看下为啥,如果有必要就更新下快照 |
好的 |
样式上还有点小问题,官方是hover的时候只有水波纹,按下去里面的滑块才会变大,还有一个就是亮色模式并打开switch的时候hover效果会导致滑块颜色改变,这里颜色应该是不会变化的 |
收到, 已经在改进了 |
我点击switch其他的地方,switch的块应该也会变大,这是官方的实现 |
明白, 我看了你发的示例,在开和关的情况下还有个小回弹的效果,但是在另个示例中却没有这个回弹效果 |
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
close #1550
Related Links
Links related to this pr.