Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-bar): add placeholder prop #1643

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Conversation

YHoney7
Copy link
Member

@YHoney7 YHoney7 commented May 30, 2024

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

close #1610

Related Links

Links related to this pr.

Copy link

vercel bot commented May 30, 2024

@YHoney7 is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 3:20pm

@YHoney7 YHoney7 changed the title feat(app-bar): add placeholder prop WIP(app-bar): add placeholder prop May 30, 2024
@YHoney7 YHoney7 changed the title WIP(app-bar): add placeholder prop feat(app-bar): add placeholder prop May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (8ff21b9) to head (d9781ad).
Report is 10 commits behind head on dev.

Current head d9781ad differs from pull request most recent head ccf3824

Please upload reports for the commit ccf3824 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1643      +/-   ##
==========================================
+ Coverage   92.78%   92.79%   +0.01%     
==========================================
  Files         307      307              
  Lines        7203     7213      +10     
  Branches     1794     1796       +2     
==========================================
+ Hits         6683     6693      +10     
  Misses        453      453              
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoziqaq haoziqaq merged commit f0c5afe into varletjs:dev Jun 1, 2024
3 of 4 checks passed
@YHoney7 YHoney7 deleted the feat-app-bar branch June 2, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

是否能给appBar添加固定在顶部的api
3 participants