varlink-certification: remove unnecessary alloc

Remove unnecessary String allocation in varlink-certification tests

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Author: epilys

varlink-certification/src/test.rs

@@ -4,11 +4,9 @@ use varlink::Connection;
 
 pub type Result<T> = std::result::Result<T, Box<dyn std::error::Error>>;
 
-fn run_self_test(address: String) -> Result<()> {
-    let client_address = address.clone();
-
+fn run_self_test(address: &'static str) -> Result<()> {
     let child = thread::spawn(move || {
-        if let Err(e) = crate::run_server(&address, 4) {
+        if let Err(e) = crate::run_server(address, 4) {
             match e.kind() {
                 ::varlink::ErrorKind::Timeout => {}
                 _ => panic!("error: {:#?}", e),
@@ -19,7 +17,7 @@ fn run_self_test(address: String) -> Result<()> {
     // give server time to start
     thread::sleep(time::Duration::from_secs(1));
 
-    let ret = crate::run_client(Connection::with_address(&client_address)?);
+    let ret = crate::run_client(Connection::with_address(address)?);
     if let Err(e) = ret {
         panic!("error: {:?}", e);
     }
@@ -32,21 +30,21 @@ fn run_self_test(address: String) -> Result<()> {
 
 #[test]
 fn test_unix() -> crate::Result<()> {
-    run_self_test("unix:org.varlink.certification".into())
+    run_self_test("unix:org.varlink.certification")
 }
 
 #[test]
 #[cfg(any(target_os = "linux", target_os = "android"))]
 fn test_unix_abstract() -> Result<()> {
-    run_self_test("unix:@org.varlink.certification_abs".into())
+    run_self_test("unix:@org.varlink.certification_abs")
 }
 
 #[test]
 fn test_tcp() -> Result<()> {
-    run_self_test("tcp:127.0.0.1:23456".into())
+    run_self_test("tcp:127.0.0.1:23456")
 }
 
 #[test]
 fn test_wrong_address_1() {
-    assert!(crate::run_server("tcpd:0.0.0.0:12345", 1).is_err());
+    crate::run_server("tcpd:0.0.0.0:12345", 1).unwrap_err();
 }