Auto Stack Implementation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update releases a new feature, which is virtual for all servers, which is called Auto spawner stack. It allows you to automatically stack spawners near of the same type. Tested to work, by the way. - I've also ticked off "Auto stack" in README.MD since it's now complete. - Version bump to v0.0.4.
whoops, that was meant to be in the previous commit. Creating Pull Request, and checking PHP Stan for errors.
This was originally meant to happen because v0.0.4 was the current version. We now use v0.0.5.
|
The Autostacking part looks great, thank you for working on that. There's two issues however:
The PR looks great otherwise, thank you again! |
provsalt
approved these changes
Jan 30, 2020
Soon, I plan to implement base spawn range configurable. I’ve got it all setup, just need to add it to this pull request.
|
Okay, keep this pull request open until I make spawn range configurable. Since players can decide how far a mob spawns from the player’s render in blocks. |
- Fixed varunbln#8 issue. - Implemented Spawn range configuration option. - Revert "Fix varunbln#8" first time round, and changed Spawn_Range option to 4. Since varunbln#8 is referring to Load_Range. Thanks for clarifying, @Heisenburger69 If no errors occurr, this should now be ready for merging.
|
Okay, done. Should be ready for merging, unless you have to say anything about issues that I added or made. Thank you! |
|
This looks perfect, great job! |
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So since you liked my previous pull request, I thought I'd do another one. Also, I'm making this pull request because auto stack needs to be implemented. Otherwise, players can still lag out the server with spawners, or even lag the clients.
Without this implementation, players can possibly use it to their advantage, and abuse the system.
What does this Pull request provide?
As previously stated, this pull request provides auto spawner stacking. Whenever a new spawner is placed of the same type as the previously placed, spawners will connect, stack, whatever you'd like to call it. When stacked, it will stay connected, allowing you, or the players to have an enjoyable time whilst grinding their way up to victory. Again, this is great for Factions and skyblock servers that do provide spawners.
Auto stack is also very useful because it prevents lag a ton. Yes, this plugin may well have prevented some or even a lot of the lag, but this feature should prevent lag a lot more than before.
More fixes? Late fixes
I have recently fixed a bug, where spawn range would be 4 blocks to be exact. This was simply too short. Now, I don't know what it is in vanilla, so for now, I've put it to 16. I know it's a lot, but that's just temporary until if I know whether it's right or not. Because I'm assuming the person is referring to Spawn_range code from Issue #8.
This pull request fixes #8, which should be closed if this pull request fixes their issue. Not sure how complicated this would be though, I'm just assuming he's talking about Spawn range, since that was 4 blocks, and he stated around 5 blocks. Plus, the name seems similar to his issue. So I just went along with that.
This has also been tested to work with the latest versions of Pocketmine, and its latest plugin dev builds.
Anything else we need to know about?
No, except I've bumped plugin version to v0.0.5. I hope you don't mind.
Coming soon
PHP Stan Testing?
Everything's tested to work, no errors found.
Any mentions?
I would once again, like to thank you for this awesome plugin! Truly means a lot to the MCPE and Pocketmine Community!