vbdBootableStatus is not available in webui when running pv-on-pvh

[ixs]

Describe the bug
A PV guest is correctly shown in the disk tab with the "Boot flag" toggle to toggle a vbd as bootable or not.
Once the machine gets converted from pv to pv-in-pvh, this toggle is not visible anymore.
This is the correct setting for a full hvm machine, because there the bootable flag is not needed anymore as the boot order is defined in a different fashion.
For pv-in-pvh however, the bootable flag is still set just like it is for a pv guest.

To Reproduce

1. Create a pv guest.
2. shutdown the guest
3. unset the bootable flag on the vbd.
4. observe machine not starting.
5. convert machine to pv-in-pvh using xe vm-param-set domain-type=pv-in-pvh uuid=...
6. observe machine not starting with the error indicating that no bootable disk is available.
7. Set vbd to bootable using xe vbd-param-set uuid=... bootable=true
8. Start machine correctly

Expected behavior
Ability to toggle bootable flag.

Environment (please provide the following information):

• xo-web: 5.103.0 (9da65b6)

[olivierlambert]

Ah yes, we probably to add another check to display it: not just for "pv" but also "pvh". Can you confirm me the type is pv-in-pvh? That should be trivial to fix :)

[ixs]

Indeed.

# xe vm-param-get param-name=domain-type uuid=ed5dc156-969c-de27-4f2e-e1d7d8421af9
pv-in-pvh
#

I would have sent a patch but I only found the COLUMNS_VM_PV list and nothing for PHV, so I thought just open an issue.
Thx.

[olivierlambert]

@marcungeschikts we should assign someone to fix this, maybe @Rajaa-BARHTAOUI ?