feat(xo-server/vm/snapshot): handle Self Service #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
e5cafb6
to
e866342
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
e866342
to
f1cc4de
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
f1cc4de
to
4f25eda
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
4f25eda
to
0c851de
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
0c851de
to
824a350
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
2 times, most recently
from
0cfd9ab
to
107c8fc
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
107c8fc
to
f09edf1
Compare
8 tasks
julien-f
pushed a commit
that referenced
this pull request
Apr 1, 2020
…#4893) From xo-server's API's point of view, it makes more sense for the "snapshot before" feature to be implemented in xo-web since snapshotting a VM is a whole independent process on its own that requires its own API permissions. Making this change will be especially useful to not over-complicate the permissions checks for the incoming "Self Service snapshots" feature. See #3693
phil-flex
pushed a commit
to phil-flex/xen-orchestra
that referenced
this pull request
Apr 2, 2020
…vatesfr#4893) From xo-server's API's point of view, it makes more sense for the "snapshot before" feature to be implemented in xo-web since snapshotting a VM is a whole independent process on its own that requires its own API permissions. Making this change will be especially useful to not over-complicate the permissions checks for the incoming "Self Service snapshots" feature. See vatesfr#3693
pdonias
force-pushed
the
pierre-self-snapshot
branch
2 times, most recently
from
d8e92dd
to
7d1a647
Compare
pdonias
force-pushed
the
pierre-self-snapshot
branch
from
7d1a647
to
5200b3a
Compare
badrAZ
suggested changes
Apr 14, 2020
julien-f
reviewed
Apr 15, 2020
badrAZ
approved these changes
Apr 16, 2020
julien-f
requested changes
Apr 22, 2020
julien-f
approved these changes
Apr 23, 2020
pdonias
changed the title
julien-f
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3304
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged