Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/job): properly handle array arguments #5944

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Oct 11, 2021

See https://xcp-ng.org/forum/topic/5010

When creating/editing a job, properties of type array must not go through the
cross product builder, they must be saved as arrays.

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

See https://xcp-ng.org/forum/topic/5010

When creating/editing a job, properties of type `array` must not go through the
cross product builder, they must be saved as arrays.
@pdonias pdonias merged commit e2e4539 into master Oct 15, 2021
@pdonias pdonias deleted the pierre-fix-job.runSequence branch October 15, 2021 08:42
pdonias pushed a commit that referenced this pull request Oct 15, 2021
Useful to create a `job.runSequence` job. Follow-up of #5944.
pdonias added a commit that referenced this pull request Mar 25, 2022
This reverts commit e2e4539.

See #5983
See #5973
See zammad#5844

This change broke other methods' params.
pdonias added a commit that referenced this pull request Mar 25, 2022
This reverts commit e2e4539.

See #5983
See #5973
See zammad#5844

This change broke other methods' params.
pdonias added a commit that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants