Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/VM/import): ability to import XVA VM from URL #6130

Merged
merged 14 commits into from
Mar 29, 2022
Merged

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Mar 4, 2022

Screenshot

Capture d’écran de 2022-03-21 11-29-40

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA changed the title WiP: feat(VM/import): VM import from URL feat(VM/import): VM import from URL Mar 4, 2022
@MathieuRA MathieuRA self-assigned this Mar 7, 2022
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing CHANGELOG

packages/xo-web/src/xo-app/vm-import/index.js Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from pdonias March 22, 2022 15:11
@MathieuRA MathieuRA requested review from Rajaa-BARHTAOUI and removed request for pdonias March 22, 2022 15:22
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 29, 2022 09:01
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 29, 2022 09:22
@pdonias pdonias changed the title feat(VM/import): VM import from URL feat(xo-web/VM/import): ability to import XVA VM from URL Mar 29, 2022
@pdonias pdonias merged commit cd408c1 into master Mar 29, 2022
@pdonias pdonias deleted the urlImport branch March 29, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants