Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/backup/restore): ability to ignore VDIs #6143

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Mar 15, 2022

Screenshots

Capture d’écran du 2022-03-15 12-53-52

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp
Copy link
Collaborator

tested and working as intended :

  • removing all vdis of a delta
  • removin one vdi of a delta
  • removing the suspended vdi of a backup with ram of a delta
  • restoring a full backup ( option not visible)

@julien-f julien-f requested a review from pdonias March 21, 2022 18:09
@julien-f
Copy link
Member

@pdonias Can you please review the UI side? 🙂

@pdonias
Copy link
Member

pdonias commented Mar 23, 2022

xo-web OK but not tested.

@julien-f julien-f merged commit dfa5009 into master Mar 24, 2022
@julien-f julien-f deleted the ignoreVdis branch March 24, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants