Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanVM): use the merged path instead of the ancestor path for size upadting after merge #6331

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jul 28, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f
Copy link
Member

Can you please add in this PR the ref of the commit that introduced this bug?

@fbeauchamp fbeauchamp marked this pull request as draft July 29, 2022 10:03
@fbeauchamp fbeauchamp force-pushed the fix_metadata_compute_after_merge branch from 5acf78a to 3cbadb6 Compare August 2, 2022 09:44
@fbeauchamp fbeauchamp marked this pull request as ready for review August 2, 2022 09:44
@julien-f julien-f merged commit 911556a into master Aug 3, 2022
@julien-f julien-f deleted the fix_metadata_compute_after_merge branch August 3, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants