Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/home/VMs): do not delete VMs when confirm modal has been cancelled #6435

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Sep 26, 2022

See Zammad#9735
Introduced by 11e09e1

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally

@pdonias pdonias changed the title fix(home/VMs): do not delete VMs when confirm modal has been cancelled fix(xo-web/home/VMs): do not delete VMs when confirm modal has been cancelled Sep 26, 2022
@pdonias pdonias merged commit 4f9636b into master Sep 26, 2022
@pdonias pdonias deleted the pierre-fix-delete-vms branch September 26, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants