Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/license): display the license product ID in SelectLicense #6512

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 4, 2022

See zammad#10750

Screenshot

Capture d’écran de 2022-11-04 16-01-21

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

enhance the option format

remove comma

changelog.md

remove unrelated change

typo
@MathieuRA MathieuRA force-pushed the mathieu/licenseDisplayProductId branch from 8b32688 to 3160efb Compare November 4, 2022 15:18
@MathieuRA MathieuRA self-assigned this Nov 4, 2022
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Show resolved Hide resolved
@pdonias pdonias changed the title fix(xo-web/license): display the license product id in SelectLicense fix(xo-web/license): display the license product ID in SelectLicense Nov 8, 2022
@pdonias pdonias merged commit 249f124 into master Nov 8, 2022
@pdonias pdonias deleted the mathieu/licenseDisplayProductId branch November 8, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants