Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@xen-orchestra/backups): tests #6597

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix(@xen-orchestra/backups): tests #6597

merged 2 commits into from
Jan 4, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Dec 23, 2022

introduced by
f6c227e (no support of directory without alias) and 6973928 (cache entries)

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp marked this pull request as ready for review January 2, 2023 07:48
@ggunullu
Copy link
Contributor

ggunullu commented Jan 2, 2023

Since it concerns a bug fix, maybe the changelog can be updated. What do you think?

@ggunullu ggunullu requested a review from julien-f January 2, 2023 10:25
@julien-f julien-f force-pushed the fix_cleanvm_test branch 2 times, most recently from c73b4f2 to 3a3f406 Compare January 4, 2023 09:46
@julien-f julien-f merged commit feef1f8 into master Jan 4, 2023
@julien-f julien-f deleted the fix_cleanvm_test branch January 4, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants